search

mintyfrankie / brilliant-CV-Submodule

Apache License 2.0
17 stars 15 forks source link

Make cvSection function optionally highlightable #14

Closed saveriogzz closed 10 months ago

saveriogzz commented 10 months ago

Ciao!

I really like this work, it's great!
I'm adding a little functionality to the cvSection function here: it's not optional to make highlight the first n (letters) characters.

Btw, I was looking for a way to check whether the file ../metadata.typ exists, and if it doesn't, to simply import ./metadata-demo.typ, but I think it doesn't exist just yet (https://github.com/typst/typst/issues/2025)

mintyfrankie commented 10 months ago

Ciao !

Thanks for the PR, very straightforward and LGTM. I will merge it tomorrow morning, together with the demo repo.

Regarding the other issue, yes I agree it's not optimal. I am hoping that Typst will have some basic error catching mechanism, such that I could implement other nice-to-have features like this.