search

mintyfrankie / brilliant-CV-Submodule

Apache License 2.0
17 stars 15 forks source link

Add i18n for header quote #7

Closed fnuttens closed 1 year ago

fnuttens commented 1 year ago

Hi! Thanks for making this gorgeous template! ✨

I'd like to propose making use of the languageSwitch for the headerQuote.

I realize that the current behavior is to disable this field if no value is set, but I guess it is also possible with the dictionary?

mintyfrankie commented 1 year ago

Hi @fnuttens thanks for the PR! I indeed wanted to make it i18n and was thinking about working on it over the weekend, but you've done it beautifully already :)

I am currently "en vacances" and even sure that your PR is probably LGTM, I will check it up and also update the main repository in the following days, once I get back to my desktop!

fnuttens commented 1 year ago

Hi, please consider reverting your latest commit so that this PR only contains changes about the headerQuote function -- we will discuss changes about headerIcons in another PR!

Oops sorry I forgot to create a new branch for this commit… Will do!

Hope you enjoyed your vacances btw 😉

mintyfrankie commented 1 year ago

Thanks @fnuttens. PR merged.