search

mintyfrankie / brilliant-CV

💼 another CV template for your job application, yet powered by Typst and more
https://typst.app/universe/package/brilliant-cv
Apache License 2.0
416 stars 19 forks source link

Ability to omit `headerQuoteInternational` #16

Closed davidedellagiustina closed 5 months ago

davidedellagiustina commented 5 months ago

Is your feature request related to a problem? Please describe. If headerQuoteInternational is left empty, the space that it takes is left blank instead of being occupied by the content that follows.

Describe the solution you'd like The vertical spacing should adjust automatically if a header quote is not provided (or empty).

mintyfrankie commented 5 months ago

Hi @davidedellagiustina thanks for the issue, and excuses for the late reply, I've been quite busy recently.

Just looked into the issue you've mentioned, and to me it seems to be more of an issue related to how header section is constructed. With a headerPhoto of 3.6cm in height, one cannot omit actually the space for headerQuote, even though it is empty.

And in my personal opinion, having consistency on the top of the page can also be great, if one is to change/delete the headerQuote frequently.

Closing this issue as it won't be treated in near future, but feel free to submit a PR if you want to suggest a better implementation.

davidedellagiustina commented 5 months ago

Thanks for your answer @mintyfrankie!

In the end, I ended up tweaking your template quite a bit here and there, and made my personal version according to my personal needs and taste.

Thank you anyway!

mintyfrankie commented 5 months ago

Thanks for your answer @mintyfrankie!

In the end, I ended up tweaking your template quite a bit here and there, and made my personal version according to my personal needs and taste.

Thank you anyway!

Good to know! 😄