search

mintyfrankie / brilliant-CV

💼 another CV template for your job application, yet powered by Typst and more
https://typst.app/universe/package/brilliant-cv
Apache License 2.0
416 stars 19 forks source link

fix: compile in all languages without error #21

Closed landry-r closed 2 months ago

landry-r commented 2 months ago

Hello,

Firstly, I have fixed the template to ensure it compiles in all languages without any modifications. There were some files missing in the language module folder which I have now added. I also had to make minor changes in the text to ensure the output fits on one page.

Secondly, I believe it doesn't make sense to have an empty language field, as both "" and "en" default to English. I propose we set English ("en") as the default language, and then the user can explicitly choose a different language if needed.

mintyfrankie commented 2 months ago

Hi @landry-r thanks for raising this PR!

I am passing this PR as the last major changes to the v1 version, and please be noted that I am working on a v2 version to be compatible to the Typst Packages standards. If you would like to contribute more to the project, with great pleasure!