search

mintyfrankie / brilliant-CV

💼 another CV template for your job application, yet powered by Typst and more
https://typst.app/universe/package/brilliant-cv
Apache License 2.0
416 stars 19 forks source link

Fix custom accent color #36

Closed alberto-lazari closed 1 month ago

alberto-lazari commented 1 month ago

Currently, when setting a custom accent color in metadata.toml, with something like

[layout]
awesome_color = 'rgb(#FF00AA)'

the code in setAccentColor checks for the type of the parameter.

Problem is, if you try getting the type of param with something like

#let metadata = toml("/metadata.toml")
#type(metadata.layout.awesome_color)

it will always print out string, so the function will always try to use one of awesomeColors

mintyfrankie commented 1 month ago

Hi @alberto-lazari thanks for spotting this issue! However your original commit doesn't compile correctly.

Just added a new patch, please check if this is working for you.

alberto-lazari commented 1 month ago

Just added a new patch, please check if this is working for you.

Thanks, this approach is definitely more intuitive. I can confirm it works for me too

mintyfrankie commented 1 month ago

Perfecto ! I will merge this patch right away.