search

mintyfrankie / brilliant-CV

💼 another CV template for your job application, yet powered by Typst and more
https://typst.app/universe/package/brilliant-cv
Apache License 2.0
452 stars 26 forks source link

Bottom margin is too small #69

Open oyvindskaaden opened 2 weeks ago

oyvindskaaden commented 2 weeks ago

Describe the bug The bottom margin is too small. Content interferes with the footer.

To Reproduce Steps to reproduce the behavior:

  1. Make enough entries to fill more than one page.

Expected behavior I would expect the content to do a pagebreak before reaching the footer.

Screenshots

image

Desktop (please complete the following information):

Typst Web Editor Typst version: 0.11.1

Additional context Could be added into the metadata.toml

oyvindskaaden commented 2 weeks ago

I have found that changing the margins to 

margin: (left: 1.4cm, right: 1.4cm, top: 1.0cm, bottom: 1.0cm)

the pagebreaking works correctly.

mintyfrankie commented 2 weeks ago

Hi @oyvindskaaden thanks for reporting this!

Recent version upgrade of v2.0.3 introduced a new way to handle footer, it could be that change interfering with the margin. What is your package version? If it's v2.0.3, could you please roll back to v2.0.2 and tell me if the problem persists?

oyvindskaaden commented 1 week ago

Hi!

When rolling back to v2.0.2 the footer just dissapairs:

image

It is the same behaviour as v2.0.0 through v2.0.2.

mintyfrankie commented 1 week ago

That's weird, are you having a multi-page CV?

I will look into this more in details, thanks for the extra information!

oyvindskaaden commented 1 week ago

@mintyfrankie Yep, multipage CV. In v2.0.0 through v2.0.2 the footer appears on the bottom of the last page. In v2.0.3 the footer appears on each page, but the margins are too tight.