search

minutebase / ember-dynamic-component

Ember addon to render a dynamic component
MIT License
40 stars 4 forks source link

Add deprecation warning once {{component}} PR lands in a stable release #4

Closed jasonmit closed 9 years ago

jasonmit commented 9 years ago

I think it would be wise to add a deprecation/obsolete warning in the documentation once this PR makes its way to a stable release, no longer under a feature flag.

See: https://github.com/emberjs/ember.js/pull/10093

Thoughts?

rlivsey commented 9 years ago

Completely agree.

I plan on giving the new component helper a whirl over the next few days when I've recovered from xmas/NY and then slapping a big note on the top of the README telling people they don't need to use this addon any more.

Very happy that the need for this is going away!

wbyoung commented 9 years ago

+1

Thanks for the work on this. I was able to follow your discussion through Stack Overflow and the Ember discussions and finally land on emberjs/ember.js#10093. Perhaps it wouldn't hurt to add a link to the README right now in case anyone else goes on the same hunt that I just did?

acorncom commented 9 years ago

+1 on the Readme tweak. @rlivsey happy to send in a pull request for that if you like, I followed the same path as @wbyoung ;-)

rlivsey commented 9 years ago

@acorncom pull request for README tweak would be great