minutebase / ember-dynamic-component

Ember addon to render a dynamic component
MIT License
40 stars 4 forks source link

Fix Esperanto exports using a defineProperty #6

Closed Serabe closed 5 years ago

Serabe commented 9 years ago

This change avoid a feature/bug in esperanto using Object.defineProperty for the export. Object.defineProperty does not work in IE8 in every object, only in DOM nodes.

I understand this is not this code's fault but it is a workaround until this gets fixed in esperanto/ember-cli.

rlivsey commented 9 years ago

I think this is fixed in the latest ember-cli / esperanto if it's the same issue I'm thinking of

Serabe commented 9 years ago

@rlivsey I'm using ember-cli@0.1.12.

Serabe commented 5 years ago

Closing this.