minutelabsio / Tree-of-Life-Explorer

Explore Earth's species and the relationships between them easily.
https://labs.minutelabs.io/Tree-of-Life-Explorer
GNU General Public License v3.0
33 stars 3 forks source link

Images on Parent Cards #9

Closed EverSalazar closed 6 years ago

EverSalazar commented 6 years ago

Right now, "Felidae" displays the same image as "Panthera Tigris", which can be confusing. Not sure what to do in these cases, but it feels right that Felidae has some sort of picture when it's not displaying any children, but maybe when it is displaying children, then remove the image? (maybe that would make things inconsistent or less smooth)... Or maybe find a way to indicate that the picture displayed is from a children? The Carnivora card seems to diplay several animals at the same time, which might be a good solution too, even if they're not individually recognizable. It seems that this is happening since the image pulled is actually a collage of images, but not sure where it is pulling it from, since the Wikipedia page for Felidae is also a collage.

image

wellcaffeinated commented 6 years ago

Yeah... it's tricky. The problem is I can't write any way to "know" what the images will be... I've made an update that tries to make a collage if it can, especially for MRCAs. Hopefully the images make sense. It would be helpful for you to take a look and see if the collages work...

EverSalazar commented 6 years ago

Yes, I think it works better. But I wouldn't worry too much about this issue at this point.

It appears that the higher a taxon is, the less relevant the image is. For example, what image or images are taxons like Bilateria or Sauropsida supposed to display? I'm inclined to think that maybe only the species (and maybe direct parents) should have pictures... but not sure... I'd say that this is not important for MVA (Minimum Viable App)

EverSalazar commented 6 years ago

I got a comment from a friend saying that Pan (ott417957) displayed images of statues and roman buildings: image

And is making me wonder about what the solution to this issue could be. Putting several images on a card makes them look way too busy and I think that I'm inclined to go for a single image every time. However, only cards that are not displaying children should have pictures on them (in order to avoid the confusing case of the tiger pointed at the beginning of this thread)

I'm not sure about this though... would it be possible to curate only some images and leave vast majority algorithmic? I'm thinking on overriding some of the algorithmically chosen images with our own links that we determine are better.

EverSalazar commented 6 years ago

Maybe we can disable the photos if the card has more than a certain number of descendants (if it has more than 10 or 20 descendants, for example), since the higher you go in the tree, the more difficult is to find a representative image.

Also, we could avoid images that have too much white, since they're usually schematics rather than actual photos. If there is a way to "analyze" the picture and determine if there's a single color with more than 30% presence, just ignore it.

wellcaffeinated commented 6 years ago

Unfortunately there's no easy way to analyze an image programatically. But maybe I could only show images species/subspecies/families ??

EverSalazar commented 6 years ago

I think that might work. Restricting the display of images to the near-tips would at least remove the issue of deciding what to display on upper parent cards.

On Tue, Oct 16, 2018, 9:18 PM Jasper notifications@github.com wrote:

Unfortunately there's no easy way to analyze an image programatically. But maybe I could only show images species/subspecies/families ??

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/minutelabsio/Tree-of-Life-Explorer/issues/9#issuecomment-430445757, or mute the thread https://github.com/notifications/unsubscribe-auth/AWhk7ITEJZ0HwcS-x8_YfnAA_vwQPFgPks5ulnddgaJpZM4WURvk .