search

minutemailer / react-popup

React popup component
http://minutemailer.github.io/react-popup/
MIT License
208 stars 71 forks source link

changed closeHtml from string to node - proptypes #38

Closed nemanja-tozic closed 6 years ago

nemanja-tozic commented 6 years ago

We already use a component (fontawesome component) to in place of closeHtml and it works out fine on our company project. The only reason this change is proposed is because of warnings on the console.

tbleckert commented 6 years ago

Nice, thanks! Really good and I wasn't even aware that strings (and everything else that can be rendered) also validated as nodes. I'll merge it in, appreciate it!