minutemailer / react-popup

React popup component
http://minutemailer.github.io/react-popup/
MIT License
208 stars 71 forks source link

React and ReactDOM should be as peerDependency #5

Closed Moussawi7 closed 8 years ago

Moussawi7 commented 8 years ago

Dear, First, thank for this awesome work, but may you have to update your package.json. it show:

"dependencies": {
    "react": "^0.14.0",
    "react-dom": "^0.14.0"
  },

So it will import react and react-dom even if they are already included, so may you have to put them in the peerDependency so they will be included only if they are missing. http://stackoverflow.com/questions/18875674/whats-the-difference-between-dependencies-devdependencies-and-peerdependencies Thanks.

tbleckert commented 8 years ago

Thank you!

And thanks for the dependency notice, will make a new release today.