minutils / feed-on-feeds

Released in 2003, saw the rise and fall of Google Reader, reached perfection in 2011
http://feedonfeeds.com/
GNU General Public License v2.0
14 stars 9 forks source link

Sharing link does not work. #58

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. With the plugin "sharing enabled" klick the link "not shared" next to an
item

What is the expected output? What do you see instead?
The link schould change to 'shared', but instead you get a blank page with
FALSE 

What version of the product are you using? On what operating system?
0.5 (latest)

Please provide any additional information below.

Solution: in plugins/sharing.php 

change the line:   

return "<a href=\"$shared_link\" onclick=\"$shared_link\"><img
src=\"$shared_image\" width=\"12\" height=\"12\" border=\"0\"/></a> <a
href=\"$shared_link\">$shared_text</a> ";

with: 

return "<a href=\"#\" onclick=\"$shared_link\"><img src=\"$shared_image\"
width=\"12\" height=\"12\" border=\"0\"/></a> <a href=\"#\"
onclick=\"$shared_link\">$shared_text</a> ";

Original issue reported on code.google.com by bas.jans...@gmail.com on 13 May 2009 at 1:13

GoogleCodeExporter commented 9 years ago
sorry, correct code should be: 

return "<a href=\"#\" onclick=\"$shared_link; return false;\"><img
src=\"$shared_image\" width=\"12\" height=\"12\" border=\"0\"/></a> <a 
href=\"#\"
onclick=\"$shared_link; return false;\">$shared_text</a> ";

(so page doesn't refresh) 

Original comment by bas.jans...@gmail.com on 13 May 2009 at 1:32