minvws / nl-covid19-coronacheck-app-android

European Union Public License 1.2
44 stars 29 forks source link

App displays multiple 1G certificates as a single 3G certificate #103

Closed SanderRonde closed 2 years ago

SanderRonde commented 2 years ago

Describe the bug, issue or concern

When adding multiple 1G certificates whose validities overlap, the app displays those 1G certificates in a single 3G certificate group.

E.g.

To Reproduce

Steps to reproduce the behavior:

  1. (maybe required, not sure) Add 3G certificate
  2. Add 1G certificate some time later. Let's say it expires 1 hour after you are planning to take the test the next day
  3. Add another 1G certificate. (this threw an error for me the first time so I tried again)
  4. The two certificates are now listed in a "certificate for 3G access" group and result in only a single QR code. (note that this code does scan as a 1G code so it won't break functionality).

Expected behavior

Two separate 1G certificates should be visible in the app.

Screenshots

This screenshot was kinda hard to make since of course screenshots are disabled in the app. Maybe nice to:

Smartphone (please complete the following information):

Governance

BartNijland91 commented 2 years ago

Hey, you were a bit faster than us in finding this 😄 It will be fixed in the upcoming 4.0 release

SanderRonde commented 2 years ago

Great, thanks!