(feature request) Make changing app's languague an option

marcel263 commented 3 years ago

Describe the bug, issue or concern

A clear and concise description of what the bug, issue or concern is is.

App chooses its language by the OS's preference. This may not be desired. Only by re-installing the app from Play Store, after changing OS language, does the app display correctly.

E.g.

To Reproduce

Steps to reproduce the behavior:

change Android to another language from Dutch
Open the App
Still displays in Dutch on Samsung phone
Expected behavior

Language changes along with system language and allows override from a menu

Smartphone (please complete the following information):

Device: Samsung Galaxy
OS: Android 11 OneUI 3.1
Version CoronaCheck 2.1

Additional context

App data was cleared before reinstalling, which confirmed the app's behaviour for me.

Governance

[x] I've read the contributing document https://github.com/minvws/.github/blob/master/CONTRIBUTING.md
[x] I've read and understand the Code of Conduct https://github.com/minvws/.github/blob/master/CODE_OF_CONDUCT.md
[x] I understand that any contributions or suggestions I made may make it into the actual code. I've read the License https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/LICENSE.txt and the contributor license agreement https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/CLA.md

BartNijland91 commented 3 years ago

This is very strange as this behavior is out of our control. The OS takes care of relaunching apps when changing the device language. Can you make a video of this behavior?

marcel263 commented 3 years ago

This is very strange as this behavior is out of our control. The OS takes care of relaunching apps when changing the device language. Can you make a video of this behavior?

If really needed, I could provide this. It is really just as simple as changing the OS's language within Android settings, with Coronacheck being the exception while all apps change languages.

Could this have something to do with it? My app manager tool states no English locale installed for Coronacheck. ![Uploading Screenshot_20210712-134826_App Manager.png…]()

BartNijland91 commented 3 years ago

@marcel263 Very strange, we support both English and Dutch. If you switch languages and re-open the app it should automatically pick it up (that is device OS logic, not the app). Can you provide a video of this behavior you are seeing?

ijansch commented 3 years ago

The screenshot from @marcel263's comment seems to be missing, it's still set to 'uploading..'.

@BartNijland91 could it be that it uses a different EN locale? (since there exist multiple, for UK/US English etc)

minvws / nl-covid19-coronacheck-app-android