minvws / nl-covid19-coronacheck-app-android

European Union Public License 1.2
44 stars 28 forks source link

QR is generated based on date of most recent "last dose" (booster) instead of earliest "last dose" #51

Closed Stijn-K closed 1 year ago

Stijn-K commented 3 years ago

Describe the bug, issue or concern

First I received a single dose of pfizer, which was considered my final dose as I had COVID last year. Since this was thus considered my last dose, I received a valid QR in the app. This week, because several reasons I opted to also get the 2nd shot of pfizer. Both shots are now considered the last dose of my vaccination according to the app ("is this the last dose of your vaccination? yes). The app now takes the most recent dose for the QR and now I'm unable to generate a QR. My first dose was on the 28th of june, and the 2nd dose was on the 4th of august.

E.g.

To Reproduce

Steps to reproduce the behavior:

  1. Get COVID and recover
  2. opt for a single dose of pfizer
  3. load vaccine data and enjoy your valid QR
  4. opt for a second dose of pfizer because reasons
  5. reload vaccine data and you will have to wait 14 days to enjoy your valid QR again

Expected behavior

Since I received my actual last dose already on june 28th, I should be able to generate a valid QR, regardless of any (booster) shots received after.

Smartphone (please complete the following information):

Governance

ijansch commented 2 years ago

Thanks. We are aware of this issue. It’s not android specific but I’ll leave this issue open until we release the fix.

The fix will be that in this case you will be able to also show the previous QR. Only generating it based on the original last dose would not work in some countries who might apply business rules for boosters.