minvws / nl-covid19-notification-app-backend

Server-side code for CoronaMelder.
European Union Public License 1.2
77 stars 26 forks source link

docker build #30

Closed juul-ka closed 2 years ago

juul-ka commented 3 years ago

Describe the bug, issue or concern

Docker local run fails

To Reproduce

Steps to reproduce the behavior:

  1. git clone repo
  2. cd docker
  3. docker-compose up --build
  4. Errors in Dockerfile: due deletion of Components/Framework/WindowsIdentityStuff.cs on initial run solved by using RUN rm -rf issues with the destination of csproj files and new names given to projects (CotentApi & MobileAppApi), path should be prefixed with src/

Missing projects: DbProvision/DbProvision.csproj DbFillExampleContent/DbFillExampleContent.csproj

Changed names of exe files in entrypoint in docker-compose.yml

Expected behavior

instruction from readme to run the project in docker should work without errors

Governance

skos001 commented 3 years ago

Thanks for opening this issue @juul-ka 🙂 And sincere apologies for the late response.

We've pushed a different approach for the Docker setup, which may render some of the suggested changes in your linked pull request unnecessary.

If you want, you can check to see if the current setup fixes your issue as well. If so, great! We can close the issue and corresponding pull request. If not, please feel free to either update this issue with any new findings, or open a new issue with any new findings if you prefer 😊

skos001 commented 2 years ago

@juul-ka I'm going to go ahead and close this issue and its corresponding pull request since it's been a while since my last comment, and the code base has changed a bit since you opened the original issue. 😊

The Docker setup within the project should now work without issue on Windows, Linux and macOS (excepting macOS M1, which has specific work-around instructions in the README).

However, please feel free to open a new issue and pull request if you find something is still amiss with the Docker setup 🙂