search

minvws / nl-covid19-notification-app-design

Design documentatie rondom Covid19 Notificatie App
European Union Public License 1.2
196 stars 37 forks source link

Initial English translation for all of the documentation #22

Closed ryanbnl closed 4 years ago

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

ryanbnl commented 4 years ago

@JolandaVerhoef I've added the backlinks, I thought it was overkill but given that we've also translated the filenames it's required.

JolandaVerhoef commented 4 years ago

Can you make sure that all commits are signed? See this explanation. This prevents spoofing of accounts.

ryanbnl commented 4 years ago

@JolandaVerhoef I have that setup now, do you want me to rebase -S or are the commits to-date ok? That'll sign Lennert's commits too.

jelleprins commented 4 years ago

I get a "Merging is blocked" - The base branch requires all commits to be signed.

Amazing work @ryanbnl & @lennert212 🔥

JolandaVerhoef commented 4 years ago

@ryanbnl all the commits need to be signed, otherwise we can't merge the PR. Can you rebase the branch?

lennert212 commented 4 years ago

Working on getting a GPG key

ryanbnl commented 4 years ago

Hope that worked

jelleprins commented 4 years ago

Still getting the same 🛑 Merging is blocked.

lennert212 commented 4 years ago

Still working on getting my GPG key...

lennert212 commented 4 years ago

Ok. GPG keys associated with my Github account.

ryanbnl commented 4 years ago

OK with some git-fu I have signed most of the commits; however I can't get git rebase -i -p to let me sign 28b12c0 and 4a17966. The -p is required to preserve previous merges.

I'm using the method described here:

https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits

Where you insert an x git commit -S -s --amend --no-edit after the commits you want to sign.

Does anyone have an idea?

At least this is the last time I'll skip working in a branch "because it's just documentation".

ryanbnl commented 4 years ago

git log --graph to the rescue. everything in this commit is signed now, with my sig but the author has been preserved.