search

minvws / nl-kat-coordination

OpenKAT scans networks, finds vulnerabilities and creates accessible reports. It integrates the most widely used network tools and scanning software into a modular framework, accesses external databases such as shodan, and combines the information from all these sources into clear reports. It also includes lots of cat hair.
https://openkat.nl
European Union Public License 1.2
128 stars 58 forks source link

Binaryedge code seems to support NetBlock but does not consume #1583

Open zcrt opened 1 year ago

zcrt commented 1 year ago

Describe the bug In the Binaryedge boefje the following code is present: https://github.com/minvws/nl-kat-coordination/blob/76db55aad660f2cfd0502eec305889c5f10edf9d/boefjes/boefjes/plugins/kat_binaryedge/main.py#L24-L34

However, the boefje does not consume NetBlocks: https://github.com/minvws/nl-kat-coordination/blob/76db55aad660f2cfd0502eec305889c5f10edf9d/boefjes/boefjes/plugins/kat_binaryedge/boefje.json#L5-L8

Is this on purpose?

To Reproduce See above.

Expected behavior Both addresses and ranges supported in the boefje.

OpenKAT version 1.10.1

underdarknl commented 1 year ago

I dont see a reason why we dont consume netblocs. Maybe something is missing from the normaliser which would join the findings onto the specified ip-addresses?