search

minvws / nl-kat-coordination

Repo nl-kat-coordination for minvws
European Union Public License 1.2
123 stars 55 forks source link

Required plugin reporting is a bit confusing #2007

Open zcrt opened 10 months ago

zcrt commented 10 months ago

Is your feature request related to a problem? Please describe. In the new reporting module the user will always be shown a page describing which boefjes should be enabled and have run on the object of the report. This is split in required and suggested plugins. However, when all required boefjes are already enabled and have run on the object this page is confusing as it seems to suggest things that are already set. Especially the Suggested plugins is confusing when those plugins are already enabled. In addition, it is possible to generate a report on an object with clearance level 0 while the required boefjes have level 1.

Describe the solution you'd like Rethink the required plugins page.

Additional context Based on 1.13rc2

underdarknl commented 10 months ago

'Maybe do not allow report generation if all selected objects have a clearance level too low for any of the required boefjes' this should in fact be the case.

Optionally not showing the required plugins when all requirements are already enabled seems like a good idea. But, we might still want to show any not enabled optional plugins for the user to select from. If all required and optional plugins are enabled I think we should skip this whole screen.

stephanie0x00 commented 8 months ago

'Maybe do not allow report generation if all selected objects have a clearance level too low for any of the required boefjes' this should in fact be the case.

Can confirm, I currently have only L1 objects and no objects are shown as shown in the screenshot below. This feature is available in release 1.14.0.

generate-no-objects

I have created separate issues for the other requests #2262 and #2263. I think this ticket can now be closed.

HeleenSG commented 7 months ago

Design: https://www.figma.com/file/QRL8085Z827bNdO0bIDdFL/KAT-%7C-Design-%7C-For-review?type=design&node-id=2982%3A14725&mode=design&t=9GeyaR7Bd307Skg3-1

underdarknl commented 6 months ago

Looks good to me, minor remark added when implementing this.