search

minvws / nl-kat-coordination

Repo nl-kat-coordination for minvws
European Union Public License 1.2
123 stars 55 forks source link

Current constraints on Hostames OOIs do not support internationalized/unicode hostnames #2525

Open originalsouth opened 7 months ago

originalsouth commented 7 months ago

Describe the bug Current constraints on Hostames OOIs do not support internationalized/unicode hostnames. Like for instance:

Please note that this also includes TLDs like 飞利浦 as retrieved from IANA.

See wiki with relevant RFC-3492.

Either KAT will need to support unicode or hostnames need to be punycoded like URLs.

To Reproduce Add mentioned domain names as Hostname OOI.

Expected behavior Hostames OOIs do support internationalized/unicode hostnames

OpenKAT version main (3bc5a697a1ffa1b1acf9a16f6250dded2690c533)

originalsouth commented 7 months ago

Relevant code: https://github.com/minvws/nl-kat-coordination/blob/3bc5a697a1ffa1b1acf9a16f6250dded2690c533/octopoes/octopoes/models/ooi/dns/zone.py#L30-L64

originalsouth commented 7 months ago

We have decided to represent Hostnames internally as ASCII as specified by IDN. Once that is done, we will need to decide how to represent either or both representations (ASCII and Unicode) in the web interfaces. It is useful to have both representations for a user for phishing/spoofing concerns.

originalsouth commented 6 months ago

See https://github.com/minvws/nl-kat-coordination/pull/2558#issuecomment-1966164790

originalsouth commented 6 months ago

Now that #2558 is merged, this can be addressed in the frontend.

underdarknl commented 2 months ago

The frontend(rocky) needs to transform utf-8 domains into IDN before sending them to Octopoes, or better yet, our Hostname model in Rocky should do this and wrap the utf8 internal data to be represented as IDN when needed.