search

minvws / nl-kat-coordination

OpenKAT scans networks, finds vulnerabilities and creates accessible reports. It integrates the most widely used network tools and scanning software into a modular framework, accesses external databases such as shodan, and combines the information from all these sources into clear reports. It also includes lots of cat hair.
https://openkat.nl
European Union Public License 1.2
128 stars 58 forks source link

Implementation: improved Task list design #2836

Open RomijnHumanoids opened 7 months ago

RomijnHumanoids commented 7 months ago

User feedback lead to some discussion (2484) of which these improvements are discussed for design solutions:

Plus possibly after discussing with Heleen: -❔ Find a way that users don't lose the tasks they reschedule out of sight because it shoots to the top of another page (because they are sorted by scheduled date by default) -❔ Prevent page refresh if possible --> After discussion: Design confirmation message on top of page to let users know task has been rescheduled. With the possibility of bulk actions & + confirmation message the page refresh should no longer be an obstacle. For the use case of rescheduling 1 task there is a confirmation message on top of the page that needs to be visible, and in case users want to reschedule multiple tasks the bulk action provides the possibility without losing scroll position in between every rescheduled task.

Screenshots of the current task list page will be provided to see the current functionalities.

RomijnHumanoids commented 7 months ago

Screenshots of the current task list page: Image

RomijnHumanoids commented 7 months ago

FOR REVIEW: https://www.figma.com/file/tYzng7qq8nPnfxaKJgWm71/%E2%9C%8D%F0%9F%8F%BC-KAT-%7C-For-Review-%7C-Task-list?type=design&node-id=2301%3A32986&mode=design&t=VtjDJ3bsdmpL28KF-1

RomijnHumanoids commented 7 months ago

Slight changes based on previous feedback in updated design: FOR REVIEW: https://www.figma.com/file/tYzng7qq8nPnfxaKJgWm71/%E2%9C%8D%F0%9F%8F%BC-KAT-%7C-For-Review-%7C-Task-list?type=design&node-id=2301%3A32986&mode=design&t=Sn8VRcgSRtQuQv9d-1

If approved, this ticket can be closed.

RomijnHumanoids commented 6 months ago

I have replied to some comments @underdarknl to confirm whether or not I understand it correctly, in order to make the next iteration on this design. Maybe we can meet about this after June 19th. I've put this ticket in sprint 37 (June 7-20) because if I can clear my questions up I can make a new iteration quite quickly.

RomijnHumanoids commented 5 months ago

After discussing this with @underdarknl , a design update has been made adding:

Two focus points to consider while reviewing:

FOR REVIEW: https://www.figma.com/design/tYzng7qq8nPnfxaKJgWm71/%E2%9C%8D%F0%9F%8F%BC-KAT-%7C-For-Review-%7C-Task-list?node-id=2389-31981&t=cO0YyRQxx1KQLy25-1

RomijnHumanoids commented 4 months ago

After feedback on the previous design, a design update has been made with changes:

https://www.figma.com/design/tYzng7qq8nPnfxaKJgWm71/%E2%9C%8D%F0%9F%8F%BC-KAT-%7C-For-Review-%7C-Task-list?node-id=2301-32986&t=4VHsJtJ8Fd4wC1Ti-1

NoemiOverdijk commented 4 months ago

I think it looks great! I left a few comments, but nothing major.

RomijnHumanoids commented 4 months ago

I added the small confirmation modal flow to the file. It's still for review.

Image

RomijnHumanoids commented 3 months ago

Design is approved for implementation. Implementation Figma link: https://www.figma.com/design/zoorlsXQ0ankrB4tsxusvo/%E2%9C%85-KAT-%7C-Approved-%7C-Task-List?node-id=2332-6707&t=V0VMYPf9gaRktq2d-1

jpbruinsslot commented 1 month ago

Wwith a patch request on the /tasks/{id} endpoint and `{"status": "cancelled"} the task can be cancelled. So this only needs to be implemented in rocky