search

minvws / nl-kat-coordination

Repo nl-kat-coordination for minvws
European Union Public License 1.2
123 stars 55 forks source link

Use `apt-get` instead of `apt` in scripts #2916

Open originalsouth opened 4 months ago

originalsouth commented 4 months ago

Describe the bug Use apt-get instead of apt in scripts to prevent this warning:

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

To Reproduce Steps to reproduce the behavior:

  1. make kat

Expected behavior No warning and a proper install.

Screenshots image

OpenKAT version main (fc7a5878cacf49ba442dee83df8a712e36fec352)

Additional context https://askubuntu.com/questions/990823/apt-gives-unstable-cli-interface-warning

ammar92 commented 4 months ago

If we don't specifically use apt output in our scripts, I don't see any harm in the warnings and using apt as such. But either way is fine

dekkers commented 4 months ago

Apt is not supposed to be used in scripts, so we should use apt-get. I think it might also be a good idea to add something like https://github.com/hadolint/hadolint to pre-commit to make sure we keep rid of these and other issues.