Closed Souf149 closed 1 month ago
make reset
.feature
or hotfix
works as intended.We did a live demo of the functionality to check if it works. The code stores data to a local (Garage) S3 bucket and we are also able to retrieve the data stored in bytes. It doesn't seem to break anything on main.
n/a
Requires a small change on the logging format to prevent INFO messages from flooding the Bytes logs. This is picked up in this PR.
We identified a few improvements and things that could probably be solved nicer. There are picked up in different tickets and will be created by @Souf149. These include documentation and whether or not both the PREXIX and Bucket env vars are both mandatory (by aws) or whether these can be also used separately.
Changes
Made it so that if the user adds
S3_BUCKET_PREFIX
orS3_BUCKET
to their environment variables when building OpenKAT, that OpenKAT will use S3-buckets for saving the data from boefje's raw files instead of saving them on the local disk.Issue link
Closes #3191
Demo
Example files made inside s3
Example of one of the files
QA notes
To test this feature you will need access to an existing s3 server. And inside of you
.env
file you will need to provide the following variables which are required for boto3:Outside of these you also have to specify either of the following variables to let OpenKAT know you want to use s3 for the storage of bytes:
Make sure that these are compliant with the bucket naming rules of AWS.
These are the variables I used for testing:
I made use of the s3 service garage How to setup garage How to work with garage in a container
I built a container for garage with the following docker compose file on the same host machine as
bytes
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Checklist for QA:
make reset
.feature
orhotfix
works as intended.What works:
What doesn't work:
Bug or feature?: