OpenKAT scans networks, finds vulnerabilities and creates accessible reports. It integrates the most widely used network tools and scanning software into a modular framework, accesses external databases such as shodan, and combines the information from all these sources into clear reports. It also includes lots of cat hair.
Describe the bug
Currently the Boefje.schema field shadows out BaseModel.schema. This can cause trouble, because BaseModel.schema is a dict of the schema (and BaseModel.schema_json is the JSON string representation of that dict)
To Reproduce
Run the Boefje module and monitor the logs; you should see a warning triggered by Pydantic due to the naming conflict
Expected behavior
No warnings should be triggered, and the schema should work as expected (which it probably already did).
Additional context
We should look for an alternative name
Perhaps we can use another field name, but use 'schema' as an aliased name (even if it's just for backward compatibility)
We need to make sure/ investigate it doesn't have compatibility issues when we change it
Describe the bug Currently the
Boefje.schemafield shadows outBaseModel.schema. This can cause trouble, becauseBaseModel.schemais a dict of the schema (andBaseModel.schema_jsonis the JSON string representation of that dict)To Reproduce Run the Boefje module and monitor the logs; you should see a warning triggered by Pydantic due to the naming conflict
Expected behavior No warnings should be triggered, and the schema should work as expected (which it probably already did).
Additional context