Dont show manual tasks in normalizer list

noamblitz commented 1 month ago

Changes

The normalizer task list was broken because tasks of manually added oois have no boefje (id), but manually added oois should in my opinion not show up in the task list.

Issue link

You have to create an issue to link to this PR. If this really is not possible, write a very detailed description here and add this PR to the project board directly.

Please add the link to the issue after "Closes".

Closes ...

Demo

QA notes

Please add some information for QA on how to test the newly created code.

Code Checklist

[ ] All the commits in this PR are properly PGP-signed and verified.
[ ] This PR only contains functionality relevant to the issue.
[ ] I have written unit tests for the changes or fixes I made.
[ ] I have checked the documentation and made changes where necessary.
[ ] I have performed a self-review of my code and refactored it to the best of my abilities.

[ ] Tickets have been created for newly discovered issues.
[ ] For any non-trivial functionality, I have added integration and/or end-to-end tests.
[ ] I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
[ ] I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

underdarknl commented 1 month ago

This change does mess up the page-counts, correct? Maybe the cleaner solution would be to exclude these manual jobs from the results by doing a filtered query.

noamblitz commented 1 month ago

Could also for now show them with boefje=manual. We just need a quick fix merged now.

underdarknl commented 1 month ago

Could also for now show them with boefje=manual. We just need a quick fix merged now.

That would be cleaner regarding the paginator. lets do that for now.

noamblitz commented 1 month ago

Did that, with some very small update to the table to make that look okayish

minvws / nl-kat-coordination