search

minwook-shin / notion-database

Python bindings for Notion Database API
https://pypi.org/project/notion-database/
GNU Lesser General Public License v3.0
137 stars 12 forks source link

Update setup.py #5

Closed potofpie closed 2 years ago

potofpie commented 2 years ago

Hi @minwook-shin . I am building a library on top of yours and it looks liked you missed adding your requirements to install_require array in setup.py. This leads to the requests library not being installed when you pip install the library. If you want to see the effect this change has you can run the cmds below in a venv.

python3 -m venv venv /venv/bin/pip3 install git+https://github.com/potofpie/notion-database/tree/potofpie-patch-1#egg=notion_database

minwook-shin commented 2 years ago

hello. @potofpie

i will update pypi package today as affect your packages. no other changes in this update.

thank you once again.

minwook-shin commented 2 years ago

Install notion-database==20210816.4, and check the changed in README.

thanks you!