search

minyor / syn2midi

Create pianobooster midi from youtube piano video lessons (Synthesia).
MIT License
61 stars 10 forks source link

60 fps support #2

Closed joric closed 5 years ago

joric commented 5 years ago

Wonderful software! Could you please add 60 fps support (maybe just use original video fps) for the second release, please? It's much more precise for 60 fps videos but I have to adjust tempo manually and note durations are all off.

joric commented 5 years ago

Also maybe support different colors, there are a lot of videos with yellow and blue instead of green and blue and they get converted to a single channel midi.

joric commented 5 years ago

Examples I used: https://www.reddit.com/r/videos/comments/aqy06w/youtube_channel_that_uploads_piano_tutorials_has/egl5k39/

minyor commented 5 years ago

Added a new release where I tried to fix mentioned issues. Please test it.

joric commented 5 years ago

Tried "german" and "sia" videos and mask from my link above, everything works now.

Updated midi files, now they are 100% "as is", no postprocessing.

you GERMAN you LOSE (piano edition)

Sia - Chandelier - Piano Tutorial - How to Play + Sheets

Custom colors for "sia": syn2midi -m sia.bmp -i sia.mp4 -o sia.mid -l (255,251,131) -r (166,210,255)

60 fps tempo in "german" is right, and hands in "sia" are correct.

Thanks!

P.S. used avidemux for converting videos to mp4 and this youtube downloader to download 60 fps webm videos: https://www.apowersoft.com/online-video-downloader