search

mioso / keyswarm

GNU General Public License v3.0
4 stars 3 forks source link

refactored refresh password repo operation to be executed async #72

Closed rickmer closed 4 years ago

rickmer commented 4 years ago

refactored the ui refresh operation to be executed form the task queue.

just-ole commented 4 years ago

I'm not surprised you also decided to use this function as the first candidate for encapsulating functions in tasks, I chose it as well (but it's not yet finished so I didn't push yet)

I tried running this and for whatever reason your version gets the file system tree handler stuck somehow but I'm not investigating that further because of the reasons below.

The info method you chose is not the one I would chose since it requires constant user interaction to get rid of the notification (could be solved with a timer that removed it after x seconds) but I also want to avoid using the error popup with a different color because that will cause accessibility.

I'm currently implementing a status bar in the main window that will show the description of the current task (I extented the task queue interface with some functions for getting the descriptions of the blocked/queued/running/finished tasks for that purpose) and the next push will have the status bar and the core function of this merge request which is why I'm not merging this.