mipengine / mip2

MIP (移动网页加速器)通过优化网页JS、控制资源加载顺序,达到加速网页的效果。
https://www.mipengine.org/
MIT License
184 stars 49 forks source link

fix: hide loading in mip1 site #446

Closed huanghuiquan closed 5 years ago

huanghuiquan commented 5 years ago

相关 ISSUE: (ISSUE 链接地址) 问题: MIP1站点重写 mip-layout-container 导致 MIP2 替换 MIP1 后无法隐藏 loading,

之前针对 mip-fixed display none 改为 mip-fixed display: none!important 在 ios9以下手机有兼容性问题,无法解决

站点 http://mip.cntrades.com/15995352952/sell/itemid-170607633.html

方案: 针对 mip-fixed 先把 mip-layout-container 去掉,这个不会对现有样式造成影响

1、升级点 (清晰准确的描述升级的功能点)

2、影响范围 (描述该需求上线会影响什么功能)

3、自测 Checklist

4、需要覆盖的场景和 Case

5、自测机型和浏览器

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 835


Files with Coverage Reduction New Missed Lines %
src/components/mip-img.js 3 96.48%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 818: -0.07%
Covered Lines: 3621
Relevant Lines: 3744

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 819


Totals Coverage Status
Change from base Build 818: 0.0009%
Covered Lines: 3624
Relevant Lines: 3744

💛 - Coveralls
zoumiaojiang commented 5 years ago

长线方案参考:#447