search

mipops / dvrescue

Archivist-made software that supports data migration from DV tapes into digital files suitable for long-term preservation. Snapshot daily builds are at https://mediaarea.net/download/snapshots/binary/dvrescue/.
BSD 3-Clause "New" or "Revised" License
83 stars 19 forks source link

add cc filter #800

Closed ElderOrb closed 6 months ago

ElderOrb commented 6 months ago

windows refuse to work

dericed commented 6 months ago

I get a playback error with this scenario:

  1. open a file is sidecar scc (like the Demo one) and play with with cc enabled
  2. add a second file with no scc. In the player the cc button will be off, and unresponsive, but the player file tries to use the subtitles filter and gets
[2023:12:10 15:57:01 -05:00] [warning] [thread 892416] Could not parse filter desc: "subtitles=" -22
[2023:12:10 15:57:01 -05:00] [warning] [thread 892416] FilterError : "Could not create filters: Invalid argument"

Can you add a check to make sure the subtitle file exists before putting an empty variable in the filter? And make sure that the player handles toggles between files with and without scc.

dericed commented 6 months ago

and please remove the F# part altogether. I realize that the frame number is not in context to the file but the last selected filterchain

dericed commented 6 months ago

The prior comments have been addressed. I'm testing with Demo_DV_720x480_CC.mov. I removed all sidecar removes (so there's no xml or scc). Then I drag the file into analysis view. Unfortunately, the analysis never starts. I would hope that the xml and scc would generate and then the cc button would activate.

dericed commented 6 months ago

also Demo_DV_720x480_CC.mov.dvrescue.scc works but not Demo_DV_720x480_CC.scc or Demo_DV_720x480_CC.mov.scc or Demo_DV_720x480_CC[*].scc

ElderOrb commented 6 months ago

I'm testing with Demo_DV_720x480_CC.mov. I removed all sidecar removes (so there's no xml or scc). Then I drag the file into analysis view. Unfortunately, the analysis never starts. I would hope that the xml and scc would generate and then the cc button would activate.

Hmm, could it be the case there is something wrong with permissions? Works on my env / Windows

ElderOrb commented 6 months ago

also Demo_DV_720x480_CC.mov.dvrescue.scc works but not Demo_DV_720x480_CC.scc or Demo_DV_720x480_CC.mov.scc or Demo_DV_720x480_CC[*].scc

Where can non-dvrescue.scc come from?

dericed commented 6 months ago

with the cli, the user can pick the name so it could be uncontrolled, but hopefully the file starts the same but has the scc extension. I'd like to match the behavior of other players in finding related subtitle files.

ElderOrb commented 6 months ago

with the cli, the user can pick the name so it could be uncontrolled, but hopefully the file starts the same but has the scc extension. I'd like to match the behavior of other players in finding related subtitle files.

done, although UI will run 'dvrescue -y file.dv -x file.dv.dvrescue.xml -c file.dv.dvrescue.scc' thus resulting dvrescue.scc