search

mipops / dvrescue

Archivist-made software that supports data migration from DV tapes into digital files suitable for long-term preservation. Snapshot daily builds are at https://mediaarea.net/download/snapshots/binary/dvrescue/.
BSD 3-Clause "New" or "Revised" License
83 stars 19 forks source link

make the xml and scc output options specific to the dv output #811

Open dericed opened 5 months ago

dericed commented 5 months ago

for instance with dvrescue device://0 --merge-output-speed --merge-output-concealed -m speed_concealed3.dv --merge-ignore-speed --merge-ignore-concealed -m nospeed_noconcealed3.dv --merge-output-speed --merge-ignore-concealed -m speed_noconcealed3.dv --merge-ignore-speed --merge-output-concealed -m nospeed_concealed3.dv -x out.xml I get 4 dv outputs and 1 xml output. The frame counts of the dv outputs are all different (since I manipulated the deck during the capture to create frames to trigger the filters), so the out.xml contents match only the output to speed_concealed3.dv.

We should either make the xml and scc outputs to be output specific, or say that their contents only are intended to match the first output.

JeromeMartinez commented 2 weeks ago

We should either make the xml and scc outputs to be output specific, or say that their contents only are intended to match the first output.

Maybe a misunderstanding there, the XML includes all frames and provides information about concealed frames etc, without skipping any frame (so including concealed etc), so it is same for all outputs. Which difference in XML is intended there?

About SCC, do you think about time codes, they should be in sync with the output frames and not the input (concealed etc)?

dericed commented 2 weeks ago

Ah, then if using the option to skip some frames then the scc would be out of sync with the output. I'd like the scc and xml to reflect the output rather than the input by default.

JeromeMartinez commented 2 weeks ago

I'd like the scc and xml to reflect the output rather than the input by default.

So no more information in the XML about discarded frames, right? Or in a different way?

dericed commented 2 weeks ago

I suppose my instinct is that the xml reflect the output, so dvrescue device://0 -ignore... -x 1.xml -m 1.dv --keep... -x 2.xml -m 2.dv keeps the xml option about the next output (similar to ffmpeg), but the info about discarded frames should be documented somewhere. I think the log is the better place for that.

dericed commented 1 week ago

I'd like this resolved before the next release. The xml is used for many functions in dvpackager and if the output is a filtered input AND the xml represents the input, then dvpackager's use of the xml could produce inaccuracies and the scc could be out of sync with the output.