mipops / dvrescue

Archivist-made software that supports data migration from DV tapes into digital files suitable for long-term preservation. Snapshot daily builds are at https://mediaarea.net/download/snapshots/binary/dvrescue/.
BSD 3-Clause "New" or "Revised" License
93 stars 20 forks source link

use ignore and merge options for frame filtering #812

Closed dericed closed 7 months ago

dericed commented 8 months ago

The checkboxes for frame filtering are in the settings panel but not implemented. I see the capture command constructed at https://github.com/mipops/dvrescue/blob/41c3200da9f20be87543e75a1a8aed80b02212ba/Source/GUI/dvrescue/dvrescue/DvRescueCLI.qml#L288.

Based on the settings checkboxes we should use

These options are output specific so in the capture command of:

-m file -m -

The piped output for playback should always include --merge-output-speed and --merge-output-concealed, but the file output options are set by the user, so it should be:

--userSelectedSpeedOption --userSelectedConcealedOption -m file --merge-output-speed --merge-output-concealed -m -

This way all frames are sent to player but frames selected to send to the output file are controlled by the user's settings.