search

miptsu / navi_dont_sleep

Navi sleep prevention (see https://gitlab.freedesktop.org/drm/amd/issues/892#note_426367 )
0 stars 0 forks source link

Post Info on Usage in README.md #1

Closed gardotd426 closed 4 years ago

gardotd426 commented 4 years ago

There's no information whatsoever on how to actually use this, I'm assuming it's installed with:

git clone https://github.com/miptsu/navi_dont_sleep.git
cd navi_dont_sleep
mkdir build && cd build
cmake ..
make && sudo make install

but there's no indication whatsoever on how to actually run the program, turn navi_dont_sleep on or off, etc.

gardotd426 commented 4 years ago

If @miptsu doesn't add any directions to the README, you also need vtk installed, not just opencv, and you basically do what I suggested above:

git clone https://github.com/miptsu/navi_dont_sleep.git
cd navi_dont_sleep
mkdir build; cd build
cmake ..
make

at which point you'll have the executable in the build/ directory. When you run it a window pops up showing a clock of how long the program has been running, I'm assuming the program is running while that window is open.

miptsu commented 4 years ago

Thanks for command line prompt. It is in readme now.

I have no VTK. Anyone can use OpenCV without VTK if no VTK-action is planned. So one can configure OpenCV compilation process using cmake-gui etc to remove some useless(for his project) dependencies. A lot of 'how to compile OpenCV from git source code' on the internet, let me do not copy-paste that lessons here.

gardotd426 commented 4 years ago

People shouldn't be expected to custom-compile OpenCV just to remove vtk just so they can run your code, at least not without it ever even being mentioned in the README.

If someone installs OpenCV from their distributions repositories/package manager, and follows the exact instructions on the README, they'll get the errors I posted. The only way to get around those errors is to either have VTK installed, or as you said to compile OpenCV from source without vtk. None of that is mentioned anywhere. There's a difference between "copy-pasting lessons" and giving basic directions on how to run your software. I've never seen a project that required a custom-compiled library not mention that it needs to be custom-compiled.

On Tue, Mar 10, 2020 at 4:11 AM miptsu notifications@github.com wrote:

Thanks for command line prompt. It is in readme now.

I have no VTK. Anyone can use OpenCV without VTK if no VTK-action is planned. So one can configure OpenCV compilation process using cmake-gui etc to remove some useless(for his project) dependencies. A lot of 'how to compile OpenCV from git source code' on the internet, let me do not copy-paste that lessons here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/miptsu/navi_dont_sleep/issues/1?email_source=notifications&email_token=AM5Y334I6PBJZYJPX3GMH4TRGXY2DA5CNFSM4LEM6AV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOKNMZA#issuecomment-596956772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM5Y332SFPQ7TVHND6LH5QTRGXY2DANCNFSM4LEM6AVQ .

gardotd426 commented 4 years ago

Also, it doesn't work with mesa 20.0.0 or 20.1.0, only 19.3.4. with 20.0.0 you get "fatal error: cannot open file '/usr/lib/clc/gfx1010-amdgcn-mesa-mesa3d.bc' : No such file or directory"

It seems the "1010" version is only with mesa 19.3.4, mesa 20.0.0 has a bunch of variations but not 1010.

On Tue, Mar 10, 2020 at 5:27 AM Matt M gardotd426@gmail.com wrote:

People shouldn't be expected to custom-compile OpenCV just to remove vtk just so they can run your code, at least not without it ever even being mentioned in the README.

If someone installs OpenCV from their distributions repositories/package manager, and follows the exact instructions on the README, they'll get the errors I posted. The only way to get around those errors is to either have VTK installed, or as you said to compile OpenCV from source without vtk. None of that is mentioned anywhere. There's a difference between "copy-pasting lessons" and giving basic directions on how to run your software. I've never seen a project that required a custom-compiled library not mention that it needs to be custom-compiled.

On Tue, Mar 10, 2020 at 4:11 AM miptsu notifications@github.com wrote:

Thanks for command line prompt. It is in readme now.

I have no VTK. Anyone can use OpenCV without VTK if no VTK-action is planned. So one can configure OpenCV compilation process using cmake-gui etc to remove some useless(for his project) dependencies. A lot of 'how to compile OpenCV from git source code' on the internet, let me do not copy-paste that lessons here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/miptsu/navi_dont_sleep/issues/1?email_source=notifications&email_token=AM5Y334I6PBJZYJPX3GMH4TRGXY2DA5CNFSM4LEM6AV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOKNMZA#issuecomment-596956772, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM5Y332SFPQ7TVHND6LH5QTRGXY2DANCNFSM4LEM6AVQ .

miptsu commented 4 years ago

I am not responsible for OpenCV library. I also can not predict all possible errors arising while using this library. This is the first time I see VTK issue, and this is OpenCV issue so you'd better write to OpenCV project issue tracker. All I can say now, installing VTK is overkill, it is better to disable it in cmake (cmake-gui app) while compiling OpenCV from github source. Also I guess it is a common way for github to compile from source, so using cmake (and very convenient cmake-gui application) should not be named as 'problem' even for large and mature project as OpenCV. Feel free to write here what do you need to be written on readme to avoid such issues (except OpenCV compile issues as I mentioned above).

miptsu commented 4 years ago

As for 'mesa 20.0.0 or 20.1.0, only 19.3.4' -- you need appropriate Navi driver for OpenCL support. Check AMD site for instructions. I added this to the readme, thanks.

gardotd426 commented 4 years ago

Are you using amdgpu-pro? OpenCL still doesn't have navi support on the open drivers

On Tue, Mar 10, 2020 at 5:54 AM miptsu notifications@github.com wrote:

As for 'mesa 20.0.0 or 20.1.0, only 19.3.4' -- you need appropriate Navi driver for OpenCL support. Check AMD site for instructions. I added this to the readme, thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/miptsu/navi_dont_sleep/issues/1?email_source=notifications&email_token=AM5Y334IZAAI6OOLVJCXTXTRGYE4NA5CNFSM4LEM6AV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOKXR5I#issuecomment-596998389, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM5Y337F3DSNAE7LA3CJERTRGYE4NANCNFSM4LEM6AVQ .

miptsu commented 4 years ago

Yes , amdgpu-pro-19.50-967956-ubuntu-18.04, ./amdgpu-install -y --opencl=pal .