search

miqe / ken.js

Ethiopian Date converter that works for the browser and node.js
7 stars 1 forks source link

Reason about the calander conversation algorithm #16

Open m3hari opened 7 years ago

m3hari commented 7 years ago

Currently, the conversation algorithm seems to lack a research(mathematical) background. It just follows some kind of pattern. I think the conversation algorithm need to be based on some decent research background.

The following links might be a reference

miqe commented 7 years ago

True, i came up with the patter with some research based on printed previous year calendar which are distributed by multiple companies. From my perspective its not the pattern/algorithm which is incorrect but the implementation. With the help of automated testing, which is on the previous commit https://github.com/Miqe/ken.js/commit/9f253272ec46885203f3826b366ae8a28d54c9b5 the pattern/algorithm implementation can be perfected thus leading to a new way of converting Ethiopian date to Gregorian and vice versa.

m3hari commented 7 years ago

Great! It would be awosem if the alogithm/pattern can be clearly included in the README section.