search

miquelbeltran / flutter95

Windows95 UI components for Flutter apps. Bring back the nostalgic look and feel of old operating systems with this set of UI components ready to use.
https://pub.dev/packages/flutter95
MIT License
195 stars 23 forks source link

Feat: Make context menus closer to the original #15

Open filiph opened 1 year ago

filiph commented 1 year ago

I'd like to bring Menu95 closer to this:

win95desktop2

Note the blue mouse hover, the separator lines, the padding, the > arrow.

Not a high priority, but I thought I'd put this down somewhere, and this is the best place. I might get to this at some point myself.

kelvinwieth commented 1 year ago

Can I work on this?

miquelbeltran commented 1 year ago

@kelvinwieth you can work on this, but there is no ticket assignment, just send a PR when ready!

vaibhavppandey commented 1 year ago

@miquelbeltran if @kelvinwieth is not currently working on this, I would love to try this out

kelvinwieth commented 1 year ago

@miquelbeltran if @kelvinwieth is not currently working on this, I would love to try this out

Hey @vaibhavppandey, I'm working on this, but since there's no ticket assignment, idk how is the correct approach. All I can say is that I will probably open the PR until next sunday.

vaibhavppandey commented 1 year ago

@miquelbeltran if @kelvinwieth is not currently working on this, I would love to try this out

Hey @vaibhavppandey, I'm working on this, but since there's no ticket assignment, idk how is the correct approach. All I can say is that I will probably open the PR until next sunday.

Oh hey @kelvinwieth . My bad, I did not notice that this issue is not assigned to you. I am eager to contribute and since it is taking a bit longer, can I help or maybe we can work together? Let me know :)

kelvinwieth commented 1 year ago

Oh hey @kelvinwieth . My bad, I did not notice that this issue is not assigned to you. I am eager to contribute and since it is taking a bit longer, can I help or maybe we can work together? Let me know :)

I'm not sure if I can finish this week, so you can work on this, @vaibhavppandey.

Also, here is some things I discovered:

  1. The easiest way to customize a menu style would be to wrap the PopupMenuEntry with a Theme, and change things like hoverColor;
  2. In our case, this is not possible because a Menu95 is displayed with the Flutter showMenu method, and therefore it cannot be wrapped by any widget;
  3. So, my guess is that we could change the api, and do something like Menu95(items).show(context) instead of showMenu95(items);
  4. I think this would be a decrease in the developer experience, and that's why I was exploring new ideas, including the usage of MenuAnchor.