search

miquelbrazil / docker-ngrok

MIT License
1 stars 0 forks source link

Unable to add Tunnel with subdomain #1

Open miquelbrazil opened 4 years ago

miquelbrazil commented 4 years ago

The base devilbox/docker-ngrok does not support adding subdomains to a Tunnel definition. Fork repo to build a way to support this and offer as a Pull Request to the main project.

A discussion about this issue can be found here.

miquelbrazil commented 4 years ago

The primary reason for adding support for subdomains is to enable local development for NetSuite extensions that require access to the developers local environment.

An initial implementation approach was to include a hard-coded Tunnel with the necessary configuration. However, duplicate keys cannot be used in a YAML file and the tunnels key is added as a root key by the default etnrypoint script functions. The entrypoint script also adds keys for authkey and region placing the tunnels key at the end. Because of these appends, it isn't possible to hard-code a Tunnel definition that would be in the correct place without a dynamic insertion.

miquelbrazil commented 4 years ago

In an effort to move forward with development, the Tunnel insertion functions have been temporarily removed from the docker-entrypoint.sh script and the specific Tunnel necessary for development is hard-coded in the ngrok.yml file.