search

miqwit / dedex

A generic efficient DDEX parser. Parse seemlessly the complex DDEX format and transform it into classes easily useable in your PHP project. Supports several versions (3.8.2, 4.1, 4.1.1) and is listed in the official DDEX page: https://kb.ddex.net/display/HBK/Open+Source+Software
MIT License
23 stars 11 forks source link

Fix UTF8 handling #31

Closed ignacioalles closed 3 months ago

ignacioalles commented 4 months ago

Fix issue #30 by storing un-trimmed value in last element reference.

miqwit commented 4 months ago

hello @ignacioalles. Any update on this?

ignacioalles commented 4 months ago

I was waiting to hear your thoughts on the bug or the fix as you said it was not clear to you

miqwit commented 4 months ago

Ha ok. Now it's clear, thanks. I've made a code review above, mentioning some improvement if you don't mind to update your PR. I can do it myself too, if you're fine with that.

ignacioalles commented 4 months ago

I can't see your code review. Am I missing something? Also feel free to make any change you consider in my PR.

miqwit commented 4 months ago

Ah OK my bad, I never submitted my changes. Now it's not, you can see it. I let you read it, it's very minor. I'll proceed to the changes and submit later, then. Thanks!

miqwit commented 3 months ago

It's merged and released in 2.0.7 @ignacioalles. Thank you for your contribution. I'd like to make progress on another PR but I'd need former version of DDEX ERN messages. If you happen to be able to provide some (anonymised, removing Party IDs and renaming artists and track names), let me know, it would be greatly appreciated.

ignacioalles commented 3 months ago

I don't have much information on samples of other ddex versions. I mainly use 3.8.2 but I think it is useful to have a way to support other versions without forking the entire project.