search

mir-abir-hossain / real-history-of-Bangladesh

We are taking several history books about Bangladesh and building a RAG system. The goal is to make people know any specific event of history within seconds.
MIT License
18 stars 12 forks source link

cleaned up the chunk 2 #29

Closed mir-abir-hossain closed 1 month ago

mir-abir-hossain commented 2 months ago

There are lot of English dialogues. Kept them as it is. Fixed spelling mistakes according to the original book. Some lines were not extracted. Added them.

mir-abir-hossain commented 2 months ago

@dg1223 please do a review when you have time.

mir-abir-hossain commented 2 months ago

Thank you very much @dg1223 for pointing out the errors. I have fixed those spelling mistakes and some additional more spelling mistakes. Also I was able to find out almost 8/9 missing lines that I didn't capture in the first try. I have added all the lines and I have made sure no more line is missing. About spelling mistakes, I am hopeful 95%+ mistakes are corrected. Thanks for the wonderful review. Please if you have time can you go through it once and then merge it?

mir-abir-hossain commented 1 month ago

Thank you for the rereview। Done the corrections. @dg1223

dg1223 commented 1 month ago

@mir-abir-hossain Now that your PR has been merged, maybe you can delete your branch from here:

https://github.com/mir-abir-hossain/real-history-of-Bangladesh/branches