mir-dataset-loaders / mirdata

Python library for working with Music Information Retrieval datasets

https://mirdata.readthedocs.io/en/stable/

BSD 3-Clause "New" or "Revised" License

351 stars 59 forks source link

580 mirdata multiple fixes #581

Closed guillemcortes closed 1 year ago

guillemcortes commented 1 year ago

Addressing #580

Fix tox for formatting test
Pin black version to 23.1.0 --> rollback, will do when terminating python3.6 support
Upgrade librosa version and ensure python3.6 compatibility
Black formatting with new 23.1.0 version
Fixing egfxset expected return value
Mock pandas import at sphinx autodoc
Fix black version for python3.6

guillemcortes commented 1 year ago

Discussion: https://github.com/mir-dataset-loaders/mirdata/issues/580

codecov[bot] commented 1 year ago

Codecov Report

Merging #581 (6c5a1c8) into master (c9fd249) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   96.85%   96.84%   -0.01%     
==========================================
  Files          55       56       +1     
  Lines        6705     6717      +12     
==========================================
+ Hits         6494     6505      +11     
- Misses        211      212       +1

genisplaja commented 1 year ago

I think that looks good! Thanks @guillemcortes :) That would fix what we discussed last week. What do you guys think @harshpalan, @magdalenafuentes, @nkundiushuti? Should we merge?