mir-dataset-loaders / mirdata

Python library for working with Music Information Retrieval datasets
https://mirdata.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
351 stars 59 forks source link

Adding loader for BAF dataset #583

Closed guillemcortes closed 1 year ago

guillemcortes commented 1 year ago

Adding loader for BAF

Please use the following title: "Adding loader for MyDATASET". If your pull request is work in progress, change your title to "[WIP] Adding loader for MyDATASET" to avoid reviews while the loader is not ready.

Description

Please include the following information at the top level docstring for the dataset's module mydataset.py:

Dataset loaders checklist:

If your dataset is not fully downloadable there are two extra steps you should follow:

Please-do-not-edit flag

To reduce friction, we will make commits on top of contributor's pull requests by default unless they use the please-do-not-edit flag. If you don't want this to happen don't forget to add the flag when you start your pull request.

codecov[bot] commented 1 year ago

Codecov Report

Merging #583 (2834da4) into master (0620b8c) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   96.84%   96.88%   +0.04%     
==========================================
  Files          56       57       +1     
  Lines        6717     6816      +99     
==========================================
+ Hits         6505     6604      +99     
  Misses        212      212              
guillemcortes commented 1 year ago

Hi @genisplaja, thanka for your comments, I've done the according modifications. I've also improved the csv2pandas management and atomized the function. I think now it's better. I've also included the corresponding test. Would you mind checking it? Thanks!

genisplaja commented 1 year ago

That's nice! That is ready to go in my opinion. Thanks @guillemcortes :) Maybe @harshpalan or @magdalenafuentes could take a look? πŸ™πŸΌπŸ™πŸΌπŸ™πŸΌ