Closed guillemcortes closed 1 year ago
Merging #583 (2834da4) into master (0620b8c) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 96.84% 96.88% +0.04%
==========================================
Files 56 57 +1
Lines 6717 6816 +99
==========================================
+ Hits 6505 6604 +99
Misses 212 212
Hi @genisplaja, thanka for your comments, I've done the according modifications. I've also improved the csv2pandas management and atomized the function. I think now it's better. I've also included the corresponding test. Would you mind checking it? Thanks!
That's nice! That is ready to go in my opinion. Thanks @guillemcortes :) Maybe @harshpalan or @magdalenafuentes could take a look? ππΌππΌππΌ
Adding loader for BAF
Please use the following title: "Adding loader for MyDATASET". If your pull request is work in progress, change your title to "[WIP] Adding loader for MyDATASET" to avoid reviews while the loader is not ready.
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.mirdata/indexes/
e.g.my_dataset_index.json
.mirdata/my_dataset.py
tests/datasets/
, e.g.test_my_dataset.py
docs/source/mirdata.rst
anddocs/source/table.rst
tests/test_full_dataset.py
on your dataset.If your dataset is not fully downloadable there are two extra steps you should follow:
pytest -s tests/test_full_dataset.py --local --dataset my_dataset
once on your dataset locally and confirmed it passesPlease-do-not-edit flag
To reduce friction, we will make commits on top of contributor's pull requests by default unless they use the
please-do-not-edit
flag. If you don't want this to happen don't forget to add the flag when you start your pull request.