Open carlthome opened 11 months ago
Hmm, how could I get a review on this? Ping @rabitt, @magdalenafuentes do you have time to spare?
Hey @carlthome, thanks for this PR and sorry for the slow response on our side. We've recently migrated soundata to GitHub actions and updated Python and packages version, and we're looking into doing the same in mirdata in the following couple of weeks, so we're holding a bit on the other PRs for the moment to incorporate those changes first and then have the PRs tested with the updated pipeline. We'll make sure to look at your PRs as soon as we finish that up so you'll hear from us soon. Thanks for your patience!
Merging #589 (185036a) into master (459833a) will decrease coverage by
0.02%
. The diff coverage is96.15%
.
Think this is ready to go now but technically this is a user breaking change so I'm a bit worried and would like some guidance on how to land this.
Awesome @carlthome ! Will try to take a look at it the next week. Thanks again!
Any updates on this?
Hi @carlthome ! Sorry for the radio silence, we have this on the radar and we will have a response next week for sure. Thanks for your patience!
Hi @carlthome , we've continued discussing this with the team and we think that we're ready to merge this once the suggested changes are made. Also, we believe that it could be great to manage the multiannotators similarly to how it's done in soundata. There's a PR in mirdata that's been opened for a while https://github.com/mir-dataset-loaders/mirdata/pull/515 that we plan to work on, and once that is merged we could adapt SALAMI to use this MultiAnnotator functionality. What are your thoughts on that?
Hi @carlthome, I hope you are doing well. Have you had time to work on this? let us know if you need any help.
This branch works with MSAF (which expects JAMS files and calls mir_eval internally in a joblib loop):