mir-dataset-loaders / mirdata

Python library for working with Music Information Retrieval datasets
https://mirdata.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
351 stars 59 forks source link

Missing comma in setup.py causes clean installation to fail #601

Closed jimearruti closed 8 months ago

jimearruti commented 8 months ago

Hi all. I've tried to do a clean install and it's failing due to a missing comma in setup.py:

        extras_require={
            "tests": [
                "decorator>=5.1.1"
                "pytest>=4.4.0", 
                "pytest-cov>=2.6.1",
                "pytest-pep8>=1.0.0",
                "pytest-mock>=1.10.1",
                "pytest-localserver>=0.5.0",
                "testcontainers>=2.3",
                "future==0.17.1",
                "coveralls>=1.7.0",
                "types-PyYAML",
                "types-chardet",
                "smart_open[all] >= 5.0.0",
            ],

The comma is missing after decorator.

I'll submit a PR as soon as I can :)

guillemcortes commented 8 months ago

Thanks Jimena! I'll take a look right now.

guillemcortes commented 8 months ago

I just merged the changes. I've tried doing a clean install pip install . in a new environment and everything looks fine. Let me know otherwise. Thanks again!