Closed tanmayy24 closed 8 months ago
Merging #606 (56ae563) into master (496eb4a) will increase coverage by
0.11%
. Report is 10 commits behind head on master. The diff coverage is98.99%
.
@@ Coverage Diff @@
## master #606 +/- ##
==========================================
+ Coverage 96.96% 97.08% +0.11%
==========================================
Files 58 62 +4
Lines 6990 7277 +287
==========================================
+ Hits 6778 7065 +287
Misses 212 212
Candombe dataset
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.mirdata/indexes/
e.g.my_dataset_index.json
.mirdata/my_dataset.py
tests/datasets/
, e.g.test_my_dataset.py
docs/source/mirdata.rst
anddocs/source/table.rst
tests/test_full_dataset.py
on your dataset.If your dataset is not fully downloadable there are two extra steps you should follow:
pytest -s tests/test_full_dataset.py --local --dataset my_dataset
once on your dataset locally and confirmed it passesPlease-do-not-edit flag
To reduce friction, we will make commits on top of contributor's pull requests by default unless they use the
please-do-not-edit
flag. If you don't want this to happen don't forget to add the flag when you start your pull request.As discussed with @magdalenafuentes, here's the PR regarding the dataset for "Uruguayan candombe drumming - beat and downbeat tracking data set" by Martin Rocamora and Luis Jure is now hosted in Zenodo: https://zenodo.org/record/6533068/
This PR includes a dataloader and everything needed as described in the Contributing page.
Note: this PR takes #553 and fixes the formatting issue so we can merge for release. Authored by @jimearruti