Closed tanmayy24 closed 1 month ago
Attention: Patch coverage is 97.95918%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 97.07%. Comparing base (
c1e3cf9
) to head (67d4493
).
hey @tanmayy24! Opening again this one. I just saw that I left few comments on the dataset description and tests. Maybe we could discuss that, reach an agreement and move on? Thanks!
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.mirdata/indexes/
e.g.my_dataset_index.json
.mirdata/my_dataset.py
tests/datasets/
, e.g.test_my_dataset.py
docs/source/mirdata.rst
anddocs/source/table.rst
black
,flake8
andmypy
(see Running your tests locally).tests/test_full_dataset.py
on your dataset.If your dataset is not fully downloadable there are two extra steps you should follow:
pytest -s tests/test_full_dataset.py --local --dataset my_dataset
once on your dataset locally and confirmed it passes.Please-do-not-edit flag
To reduce friction, we will make commits on top of contributor's pull requests by default unless they use the
please-do-not-edit
flag. If you don't want this to happen don't forget to add the flag when you start your pull request.