search

mir-dataset-loaders / mirdata

Python library for working with Music Information Retrieval datasets
https://mirdata.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
362 stars 58 forks source link

Add fma keys dataset #625

Open stellaywong opened 8 months ago

stellaywong commented 8 months ago

This adds support for the FMA Keys dataset, which is a new dataset for the evaluation of key detection containing 340 hours (5489 songs) of song-level key and mode annotations, spread across 17 genres.

magdalenafuentes commented 3 weeks ago

@stellaywong thanks for contributing to mirdata! Just FYI, we're about to make a release for ISMIR in a couple of weeks. Do you have time to address this changes before? It would be great to include this loader in the release! If you don't have the time don't worry, but please let us know

stellaywong commented 2 weeks ago

Thank you for the reviews! I've made the changes and pushed the updates.

It looks like the PR build is stuck waiting for status to be reported? Do you know how we can kick start the build?

genisplaja commented 1 week ago

Hey @stellaywong, thanks for the update :) Sorry that I was afk for a few days. OK, that looks quite good, you are missing a few things that I am gonna list in my next review, but the loader looks good! Hope that you will have some time to do the final updates... thanks for the patience!