mir-dataset-loaders / mirdata

Python library for working with Music Information Retrieval datasets
https://mirdata.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
363 stars 58 forks source link

Large Index Zenodo Remote Migration #632

Closed tanmayy24 closed 2 weeks ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.05%. Comparing base (ba0a902) to head (0bb58c1). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #632 +/- ## ========================================== - Coverage 97.13% 97.05% -0.08% ========================================== Files 66 66 Lines 7493 7503 +10 ========================================== + Hits 7278 7282 +4 - Misses 215 221 +6 ```
guillemcortes commented 3 weeks ago

Hi @tanmayy24 ! We've been checking the PR with @genisplaja and we believe that we should replicate the changes done in Soundata (PR: https://github.com/soundata/soundata/pull/169/) this includes the following pending changes (even though there might be other that we missed):

guillemcortes commented 2 weeks ago

EDIT: I wrote this before actually reviewing the PR. I detailed all necessary changes in furhter comments so this one can be ignored (even though I think it is still a good idea to check that PR)

It would be great to double check with what we did in Soundata to make sure we are not missing anything. Here's the TODO list of that PR. I think that we are missing all the changes in the documentation, for instance. https://github.com/soundata/soundata/pull/169#issuecomment-2107207637