search

mir-diablo-ii-tools / SlashGaming-Diablo-II-Free-Resolution

A project aimed at modding Diablo II to support any resolution.
Other
106 stars 23 forks source link

Add 1.10 support #91

Closed Jarcho closed 2 years ago

Jarcho commented 2 years ago

fixes #51

IAmTrial commented 2 years ago

I think you meant to apply the changes to master branch.

IAmTrial commented 2 years ago

I have changed the base branch, and can see the changes you intended to make. I'll review it some time within the next two weeks for correctness.

Jarcho commented 2 years ago

Fixed a typo. 'B' and '8' look too similar. Should be functioning properly now.

Jarcho commented 2 years ago

Turns out this still has an error. The game crashes when opening the either of the right panels on 800x600 mode. All other resolutions appear to work, and everything else on 800x600 also appears to work.

IAmTrial commented 2 years ago

I have been a bit busy, I will try to review it as soon as I can.

Jarcho commented 2 years ago

Right panel on 800x600 has been fixed. Hopefully that's the last issue.

IAmTrial commented 2 years ago

Everything seems to be mostly correct, except for one bug that crashes the game. Once that is fixed, I will approve the changes and merge the PR.

DoctorGoat commented 2 years ago

Hooray! I'm pretty excited about this, thank you for the work