search

mir-group / flare

An open-source Python package for creating fast and accurate interatomic potentials.
https://mir-group.github.io/flare
MIT License
295 stars 71 forks source link

Can't clone flare on windows because of tests/test_files/output_files/. Possibly OUTCAR naming not allowed on windows #388

Open NicholasDow opened 11 months ago

NicholasDow commented 11 months ago

On windows when you clone the flare directory the OUTCAR files cause an error with git. I found removing the outcar files in tests/test_files/output_files/ to solve the issue. I think that the numbers at the beginning of the name aren't allowed on windows.

For example: 2021.10.19:19:44:37:OUTCAR

I was wondering if I could get permission to change the names of these files or remove them so that other windows users can clone the repository.

To Reproduce Steps to reproduce the behavior:

  1. Git fork/clone
  2. Open with github desktop
  3. See error

Error Message Cloning into 'D:\flare'... remote: Enumerating objects: 27103, done.
remote: Counting objects: 100% (9292/9292), done.
remote: Compressing objects: 100% (2756/2756), done.
remote: Total 27103 (delta 6434), reused 9120 (delta 6321), pack-reused 17811
Receiving objects: 100% (27103/27103), 167.95 MiB | 33.75 MiB/s, done. Resolving deltas: 100% (19351/19351), done. error: unable to create file tests/test_files/output_files/2021.10.19:19:44:37:OUTCAR: Invalid argument fatal: unable to checkout working tree warning: Clone succeeded, but checkout failed. You can inspect what was checked out with 'git status' and retry with 'git restore --source=HEAD :/'

YuuuXie commented 10 months ago

Hi @NicholasDow , since we can’t do any serious thing with flare on windows we are not considering it as an option for maintenance. If you want to do some tests and debugging on windows computer, I highly recommend you to use wsl (windows subsystem of Linux) and do git clone things there