miracl / amcl

33 stars 20 forks source link

Two small change suggestions #43

Closed mhewett-ks closed 5 years ago

mhewett-ks commented 5 years ago

Sorry - running short of time. Next time I'll try to generate a pull request.

  1. Allow generating a Java library on MacOS:
    
    $ git diff version3/java/config64.py 
    --- a/version3/java/config64.py
    +++ b/version3/java/config64.py
    @@ -9,7 +9,7 @@ org1text="org"
    org2text="apache"
    org3text="milagro"

-if sys.platform.startswith("linux") : +if (sys.platform.startswith("linux") or sys.platform.startswith("darwin")) : copytext="cp " deltext="rm " slashtext="/"


2. version3/java/DBIG32 and version3/java/DBIG64 have a syntax error around line 235: cast_to_chunk() is in the BIG class.  This should be caught by your test platform...
    int i,wd,bt;
    wd=m/CONFIG_BIG.BASEBITS;
    bt=m%CONFIG_BIG.BASEBITS;
mcarrickscott commented 5 years ago

point 2. was fixed already.

point 1. is a good idea..