miracl / core

MIRACL Core
Apache License 2.0
199 stars 68 forks source link

refactor: make config script deterministic for building c library, fixes #46

Closed kwvg closed 3 years ago

kwvg commented 3 years ago

The current behavior of Miracl Core's config*.py for C are as follows

These behaviors and some additional refactoring (moving globals and comments to more appropriate places) have been done, instead of one giant commit, changes have been done in steps to make reviewing easier, even if the next commit eventually neutralizes the changes done previously

mcarrickscott commented 3 years ago

Thanks! What about swift/config64.py...

mcarrickscott commented 3 years ago

Thanks! What about swift/config64.py?

kwvg commented 3 years ago

Don't really work with Swift so never looked into it, depending on this PR's response I was gonna make another one but for C++, I'll give Swift a look

mcarrickscott commented 3 years ago

Had to make a few changes. When all generated files are deleted, so were the headers! They are needed to compile test programs.

If testing, programs again run immediately (to be compatible with documentation and other languages)

Renamed Million Dollar Curve to simply MDC, as that is the name used in ROM files.

Your contribution flushed out a few other bugs, so thanks again.

Mike

On Sun, Jun 20, 2021 at 10:37 AM Kittywhiskers Van Gogh < @.***> wrote:

Don't really work with Swift so never looked into it, depending on this PR's response I was gonna make another one but for C++, I'll give Swift a look

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/miracl/core/pull/46#issuecomment-864526464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU3ZDXN5KWVMMYGMVLOCJTTTWZFLANCNFSM466ZOHJA .